-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources #1004
Conversation
…pc_service_project resources.
"github.com/hashicorp/terraform/helper/resource" | ||
) | ||
|
||
func TestAccComputeSharedVpc_importBasic(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're actually trying to get away from having separate files for import tests, because it hides the fact that we're actually duplicating a lot of our tests. Instead, can you add the TestSteps that do the import to the regular tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
Import test incorporated into main acceptance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @ewbankkit!
…pc_service_project resources (hashicorp#1004) * Import google_compute_shared_vpc_host_project/google_compute_shared_vpc_service_project resources. * Incorporate testing of resource import into main acceptance tests.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #1003.
New acceptance test: